Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored growl reporter. #296

Merged
merged 1 commit into from Mar 7, 2014

Conversation

AlphaHydrae
Copy link
Contributor

Restoring my growl reporter which I upgraded to be compatible with Jasmine 2.0.

Run node lib/jasmine-node/cli.js --growl spec to see it work.

Sorry for the double pull request. I picked the wrong branch earlier.

@AlphaHydrae
Copy link
Contributor Author

Since it looks like you're in the process of setting up new coffeescript files right now. I'll fix this tomorrow.

@tebriel
Copy link
Contributor

tebriel commented Mar 6, 2014

Yeah, sorry, went full-refactor on the repo. WIll make sure that growl is in place, just commented out.

@tebriel
Copy link
Contributor

tebriel commented Mar 6, 2014

You should be solid now. I'm done for the day. Sorry for the high volatility.

@AlphaHydrae
Copy link
Contributor Author

No problem. Should be good now.

@tebriel
Copy link
Contributor

tebriel commented Mar 7, 2014

I messed it up again, I just resolved the conflicts, they weren't bad.

@tebriel tebriel merged commit 23e1594 into mhevery:Jasmine2.0 Mar 7, 2014
@tebriel
Copy link
Contributor

tebriel commented Mar 7, 2014

Very nice! Took me a minute to remember I had to reinstall the terminal reporter, 'cause that was missing (guess it got lost when I clean-installed) but now I'm good.

@AlphaHydrae
Copy link
Contributor Author

Excellent! Thanks for the help.

@AlphaHydrae AlphaHydrae deleted the growl-reporter-upgrade branch March 7, 2014 16:13
@tebriel
Copy link
Contributor

tebriel commented Mar 7, 2014

NP. Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants